Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDF attrs bug fix #393

Merged

Conversation

tech3371
Copy link
Contributor

@tech3371 tech3371 commented Apr 5, 2024

Change Summary

added File_naming_convention to global attribute and fixed data_type in all instruments.

@tech3371 tech3371 requested review from bryan-harter and a team April 5, 2024 16:07
@tech3371 tech3371 self-assigned this Apr 5, 2024
@tech3371 tech3371 requested review from bourque, sdhoyt, greglucas, subagonsouth, vmartinez-cu, laspsandoval and maxinelasp and removed request for a team April 5, 2024 16:07
Copy link
Contributor

@maxinelasp maxinelasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, comments are clear

Copy link
Contributor

@sdhoyt sdhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@tech3371 tech3371 merged commit 87461f7 into IMAP-Science-Operations-Center:dev Apr 8, 2024
17 checks passed
@tech3371 tech3371 deleted the cdf_attrs_bug_fix branch July 25, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants